Skip to content

Added Scan management logic to perform Audit scans using Jfrog Cli #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
kerenr-jfrog merged 9 commits into from
Apr 6, 2025
Merged

Added Scan management logic to perform Audit scans using Jfrog Cli #33

kerenr-jfrog merged 9 commits into from
Apr 6, 2025

Conversation

@kerenr-jfrog
Copy link
Contributor

@kerenr-jfrog kerenr-jfrog commented Apr 2, 2025 •
edited
Loading

  • Implemented ScanManager to perform an audit scan using the Jfrog CLI.
  • In case of multiple projects, the scan will be performed by multiple threads, each one will run a background process for running an audit scan.
  • Added functionality to prevent new scans from starting if an existing scan is already in progress, ensuring orderly and non-conflicting scan operations.
  • Created the ScanCache class to aggregate scan results and maintain persistence, ensuring that results are consistently displayed in the UI.
  • Removed logic of performing a scan when the plugin is loaded.
  • Added a checkbox in the settings window to enable the generation of debug logs if necessary.

@kerenr-jfrog kerenr-jfrog added the new feature New feature or request label Apr 2, 2025
@kerenr-jfrog kerenr-jfrog self-assigned this Apr 2, 2025
@kerenr-jfrog kerenr-jfrog changed the title Implement Scan Manager using Cli Added Scan management logic to perform Audit scans using Jfrog Cli Apr 2, 2025
hadarshjfrog
hadarshjfrog reviewed Apr 2, 2025
View reviewed changes
Copy link

@hadarshjfrog hadarshjfrog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking good - basically minor cleanups

attiasas
attiasas requested changes Apr 3, 2025
View reviewed changes
Copy link

@attiasas attiasas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! check out my comments. In addition:

  1. make sure you format the changes, I can see some missing spacing in some places
  2. is it possible to start adding tests at this stage?

@kerenr-jfrog kerenr-jfrog requested a review from attiasas April 6, 2025 06:58
attiasas
attiasas reviewed Apr 6, 2025
View reviewed changes
@kerenr-jfrog kerenr-jfrog merged commit dcdb532 into jfrog:V2 Apr 6, 2025
1 check passed
@kerenr-jfrog kerenr-jfrog deleted the implement_scan_manager branch April 6, 2025 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@attiasas attiasas attiasas requested changes

+1 more reviewer

@hadarshjfrog hadarshjfrog hadarshjfrog left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@kerenr-jfrog kerenr-jfrog

Labels

new feature New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kerenr-jfrog @attiasas @hadarshjfrog